Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-153003: Encryption at Rest Tests for GCP & Azure #1035

Merged
merged 18 commits into from
Aug 9, 2023

Conversation

roothorp
Copy link
Collaborator

@roothorp roothorp commented Jul 11, 2023

All Submissions:

  • Have you signed our CLA?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
  • Update docs/release-notes/release-notes.md if your changes should be included in the release notes for the next release.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2023

test/e2e/api/aws/aws.go Outdated Show resolved Hide resolved
@josvazg
Copy link
Collaborator

josvazg commented Jul 11, 2023

LGTM overall, will approve when CI passes

test/e2e/actions/cloud/gcp.go Show resolved Hide resolved
test/e2e/actions/cloud/gcp.go Show resolved Hide resolved
test/e2e/actions/cloud/azure.go Outdated Show resolved Hide resolved
test/e2e/actions/cloud/aws.go Outdated Show resolved Hide resolved
test/e2e/encryption_at_rest_test.go Outdated Show resolved Hide resolved
test/e2e/encryption_at_rest_test.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@igor-karpukhin igor-karpukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 But let's wait for the CI to become green

@roothorp
Copy link
Collaborator Author

The new tests are failing because the CI account does not have the correct permissions to access the secret vaults; after the next release we'll switch the CI accounts to use generic CI service principals and make sure they have the correct permissions for these tests (and all the others)

@helderjs helderjs force-pushed the CLOUDP-153003-encryption-at-rest-tests branch from 4f9325b to 18ba834 Compare August 8, 2023 09:46
Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the title of the PR

For the related fix on flaky tests, I have some questions, but non of them are blocking. Just curiosity or something to follow up on.

@helderjs helderjs merged commit 0a74309 into main Aug 9, 2023
38 checks passed
@helderjs helderjs deleted the CLOUDP-153003-encryption-at-rest-tests branch August 9, 2023 09:33
@josvazg
Copy link
Collaborator

josvazg commented Aug 9, 2023

Thanks for the replies!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants