CLOUDP-153003: Encryption at Rest Tests for GCP & Azure #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josvazg
reviewed
Jul 11, 2023
josvazg
reviewed
Jul 11, 2023
josvazg
reviewed
Jul 11, 2023
|
LGTM overall, will approve when CI passes |
helderjs
requested changes
Jul 11, 2023
igor-karpukhin
approved these changes
Jul 14, 2023
|
The new tests are failing because the CI account does not have the correct permissions to access the secret vaults; after the next release we'll switch the CI accounts to use generic CI service principals and make sure they have the correct permissions for these tests (and all the others) |
helderjs
force-pushed
the
CLOUDP-153003-encryption-at-rest-tests
branch
from
4f9325b
to
18ba834
Compare
helderjs
approved these changes
Aug 8, 2023
josvazg
reviewed
Aug 9, 2023
josvazg
reviewed
Aug 9, 2023
josvazg
reviewed
Aug 9, 2023
josvazg
reviewed
Aug 9, 2023
josvazg
reviewed
Aug 9, 2023
josvazg
approved these changes
Aug 9, 2023
|
Thanks for the replies! |
cveticm
pushed a commit
that referenced
this pull request
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if there is one).